Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sticky Breadcrumbs #239

Merged
merged 1 commit into from
May 9, 2024
Merged

feat: Sticky Breadcrumbs #239

merged 1 commit into from
May 9, 2024

Conversation

oodamien
Copy link
Collaborator

@oodamien oodamien commented May 5, 2024

Resolves #237

@rwinch
Copy link
Collaborator

rwinch commented May 6, 2024

@oodamien Looks great! Please feel free to merge once you are ready

{{/if}}
</nav>
</nav>
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GH is complaining here that files should end with a new line because it's a POSIX standard. It should not be a big deal nowadays but I would still recommend adding anew line (and maybe an .editorconfig rule as well).

@oodamien oodamien merged commit 420af97 into main May 9, 2024
1 check passed
@oodamien oodamien deleted the feat/gh-237 branch June 17, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Static breadcrumbs
3 participants