Ensure Gradle tasks are configured lazily #1292
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At present, generated Gradle build scripts that use Groovy DSL configure tasks eagerly. This is both suboptimal and actually not aligned with the generated build scripts that use Kotlin DSL, which configures tasks lazily. This commit updates `GroovyDslGradleBuildWriter` to ensure tasks are configured lazily. See https://docs.gradle.org/current/userguide/task_configuration_avoidance.html for more details on the task configuration avoidance topic.
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
added
type: enhancement
and removed
status: waiting-for-triage
snicoll
pushed a commit
that referenced
this pull request
Jan 22, 2022
At present, generated Gradle build scripts that use Groovy DSL configure tasks eagerly. This is both suboptimal and actually not aligned with the generated build scripts that use Kotlin DSL, which configures tasks lazily. This commit updates `GroovyDslGradleBuildWriter` to ensure tasks are configured lazily. See gh-1292
snicoll
added a commit
that referenced
this pull request
Jan 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, generated Gradle build scripts that use Groovy DSL configure tasks eagerly. This is both suboptimal and actually not aligned with the generated build scripts that use Kotlin DSL, which configures tasks lazily.
This commit updates
GroovyDslGradleBuildWriterto ensure tasks are configured lazily.See https://docs.gradle.org/current/userguide/task_configuration_avoidance.html for more details on the task configuration avoidance topic.