Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate test app when spring cloud azure storage is selected #1582

Conversation

eddumelendez
Copy link
Contributor

Spring Cloud Azure 5.16.0 supports Testcontainers and Docker Compose
Service Connection for Blob Storage and Queue.

  • Add spring-cloud-azure-docker-compose or spring-cloud-azure-testcontainers dependency
  • Configure docker-compose.yaml with image mcr.microsoft.com/azure-storage/azurite:latest
  • Configure GenericContainer with image mcr.microsoft.com/azure-storage/azurite:latest

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 11, 2024
Spring Cloud Azure 5.16.0 supports Testcontainers and Docker Compose
Service Connection for Blob Storage and Queue.

* Add `spring-cloud-azure-docker-compose` or `spring-cloud-azure-testcontainers` dependency
* Configure `docker-compose.yaml` with image `mcr.microsoft.com/azure-storage/azurite:latest`
* Configure `GenericContainer` with image `mcr.microsoft.com/azure-storage/azurite:latest`
@mhalbritter mhalbritter self-assigned this Sep 12, 2024
@mhalbritter mhalbritter added type: enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 12, 2024
@mhalbritter
Copy link
Contributor

Hello! Thanks for the PR. Currently, we have multiple Azure dependencies:

image

Testcontainers and Docker Compose support is added based on the presence of a dependency with the group id com.azure.spring. AFAIK azurite only provides storage APIs. Should we instead make that conditional on the "Azure Storage" dependency instead of all Azure products?

@mhalbritter mhalbritter added the status: waiting-for-feedback We need additional information before we can continue label Sep 12, 2024
@eddumelendez
Copy link
Contributor Author

Hi @mhalbritter! I have updated the code to only add the dependencies when azure-storage is selected along with docker compose and testcontainers.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Sep 12, 2024
mhalbritter pushed a commit that referenced this pull request Sep 13, 2024
Spring Cloud Azure 5.16.0 supports Testcontainers and Docker Compose
Service Connection for Blob Storage and Queue.

* Add `spring-cloud-azure-docker-compose` or `spring-cloud-azure-testcontainers` dependency
* Configure `docker-compose.yaml` with image `mcr.microsoft.com/azure-storage/azurite:latest`
* Configure `GenericContainer` with image `mcr.microsoft.com/azure-storage/azurite:latest`

See gh-1582
@mhalbritter
Copy link
Contributor

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants