Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RecipeRun differs between RewriteMavenProjectParser and RewriteProjectParser #975

Open
fabapp2 opened this issue Oct 18, 2023 · 2 comments · Fixed by #976 or #978
Open

RecipeRun differs between RewriteMavenProjectParser and RewriteProjectParser #975

fabapp2 opened this issue Oct 18, 2023 · 2 comments · Fixed by #976 or #978
Assignees
@shresthaujjwal @fabapp2
Labels
in: sbm-support-rewrite Issue is related to the sbm-support-rewrite compionent revamp type: bug Something isn't working

Comments

@fabapp2
Copy link
Contributor

fabapp2 commented Oct 18, 2023

Describe the bug
Applying org.openrewrite.java.spring.boot3.UpgradeSpringBoot_3_1 against the AST from RewriteMavenProjectParser differs from the result when applied against the AS from RewriteProjectParser.

SBM Version
version/revamp branch
@fabapp2 fabapp2 added type: bug Something isn't working in: sbm-support-rewrite Issue is related to the sbm-support-rewrite compionent revamp labels Oct 18, 2023
@fabapp2
Copy link
Contributor Author

fabapp2 commented Oct 18, 2023 •
edited
Loading

Thank you @shresthaujjwal for reporting and investigating. 🚀
After commenting on this I can assign it to you.

@shresthaujjwal
Copy link

thanks @fabapp2

fabapp2 added a commit that referenced this issue Oct 19, 2023
@fabapp2
Provide test to prove bug in #975 (#976)
b119229
@fabapp2 fabapp2 linked a pull request Oct 19, 2023 that will close this issue
Provide test to prove bug in #975 #976
Merged
fabapp2 added a commit that referenced this issue Oct 19, 2023
@fabapp2
fixes #975
9f86a90
@fabapp2 fabapp2 linked a pull request Oct 19, 2023 that will close this issue
RecipeRun differs between parsers #978
Merged
@fabapp2 fabapp2 self-assigned this Oct 19, 2023
@fabapp2 fabapp2 mentioned this issue Oct 19, 2023
Merged
fabapp2 added a commit that referenced this issue Oct 19, 2023
@fabapp2
fixes #975
1af2236
fabapp2 added a commit that referenced this issue Oct 19, 2023
@fabapp2
fixes #975
65c30a5 
Fix ignore pattern and test
fabapp2 added a commit that referenced this issue Oct 19, 2023
@fabapp2
fixes #975
f16447e 
Improve default ignorePatterns
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shresthaujjwal shresthaujjwal

@fabapp2 fabapp2

Labels
in: sbm-support-rewrite Issue is related to the sbm-support-rewrite compionent revamp type: bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@shresthaujjwal @fabapp2