Skip to content

EPIC - Removing deprecated code #2861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
5 of 14 tasks
markpollack opened this issue Apr 23, 2025 · 0 comments
Open
5 of 14 tasks

EPIC - Removing deprecated code #2861

markpollack opened this issue Apr 23, 2025 · 0 comments
Assignees
Milestone

Comments

@markpollack
Copy link
Member

markpollack commented Apr 23, 2025

The next release is RC1 which will not have any @deprecated code. There is not another M8 to allow users one more release cycle to upgrade. So some changes such as

1f59cca

wrt to Advisors will be breaking changes. This needs to be clearly communicate in upgrade-notes.adoc

This is the fine grained list of what deprecated code needs to be removed.

Large Effort

  • CallAroundAdvisor needs to be removed and code updated. So does usage of AdvisedRequest, AdvisedResponse - > use ChatClientRequest and ChatClientResponse [Post M8]

Medium Effort

  • Ctors for UserMessage (To discuss: should we add builder for other Message implementations?) [Post M8]
  • All the classes in the model.function package. This requires minimax and potentially zhipu refactoring. [In M8]
  • OpenAiApi - ChatCompletionRequest - check about useage of max_tokens, other OpenAI API compatibly libraries may still use it. [In M8]
  • Remove deprecation in ObservationContext for models #2518 [In M8]

Low Effort

  • ContentFormatter was listed as deprecated, but we are going to keep it.
  • ChatModelObservationContext - remove getRequestOptions [In M8] Remove deprecation in ObservationContext for models #2518
  • Same as above for Embedding and Image modelobservationcontext. [In M8] Remove deprecation in ObservationContext for models #2518
  • ToolCallback [In M8]
  • AnthropicApi - left over 'with' Builder methods.
  • VertexAiGeminiChatOptions - some simple left over methods.
  • Deprecated test methods in ITs, e.g. BedrockProxyChatModelIT - need to make sure there are equivalents in the updated API.
  • SimpleVectorStoreContent

Update examples in our exmaples repo.

  • Move to snapshot and rebuilt the examples.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants