Skip to content

Remove deprecation in ObservationContext for models #2518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
5 of 12 tasks
ThomasVitale opened this issue Mar 19, 2025 · 0 comments · May be fixed by #2896
Open
5 of 12 tasks

Remove deprecation in ObservationContext for models #2518

ThomasVitale opened this issue Mar 19, 2025 · 0 comments · May be fixed by #2896
Assignees
@sobychacko
Labels
deprecation
Milestone
1.0.0-RC1

Comments

@ThomasVitale
Copy link
Contributor

ThomasVitale commented Mar 19, 2025 •
edited by ilayaperumalg
Loading

In 1.0.0-M6, the ".requestOptions()" method for ModelObservationContext instances has been deprecated and marked for removal. This issue is to track the changes needed to use the new strategy and remove the deprecated logic.
ThomasVitale added a commit to ThomasVitale/spring-ai that referenced this issue Mar 19, 2025
@ThomasVitale
mistral: Adopt new strategy for ObservationContext
3517ee1 
Relates to spring-projectsgh-2518

Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>
@ThomasVitale ThomasVitale mentioned this issue Mar 19, 2025
Closed
ThomasVitale added a commit to ThomasVitale/spring-ai that referenced this issue Mar 19, 2025
@ThomasVitale
ollama: Adopt new strategy for ObservationContext
74ed669 
Relates to spring-projectsgh-2518

Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>
@ThomasVitale ThomasVitale mentioned this issue Mar 19, 2025
Closed
ThomasVitale added a commit to ThomasVitale/spring-ai that referenced this issue Mar 19, 2025
@ThomasVitale
openai: Adopt new strategy for ObservationContext
39e3c6d 
Relates to spring-projectsgh-2518

Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>
@ThomasVitale ThomasVitale mentioned this issue Mar 19, 2025
Closed
ilayaperumalg pushed a commit that referenced this issue Mar 27, 2025
@ThomasVitale @ilayaperumalg
mistral: Adopt new strategy for ObservationContext
20deb0e 
Relates to gh-2518

Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>
ilayaperumalg pushed a commit that referenced this issue Mar 27, 2025
@ThomasVitale @ilayaperumalg
ollama: Adopt new strategy for ObservationContext
3d1825d 
Relates to gh-2518

Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>
ilayaperumalg pushed a commit that referenced this issue Mar 27, 2025
@ThomasVitale @ilayaperumalg
openai: Adopt new strategy for ObservationContext
24fb447 
Relates to gh-2518

Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>
leijendary pushed a commit to leijendary/spring-ai that referenced this issue Mar 28, 2025
@ThomasVitale @leijendary
mistral: Adopt new strategy for ObservationContext
7e780a0 
Relates to spring-projectsgh-2518

Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>
leijendary pushed a commit to leijendary/spring-ai that referenced this issue Mar 28, 2025
@ThomasVitale @leijendary
ollama: Adopt new strategy for ObservationContext
bc3c941 
Relates to spring-projectsgh-2518

Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>
leijendary pushed a commit to leijendary/spring-ai that referenced this issue Mar 28, 2025
@ThomasVitale @leijendary
openai: Adopt new strategy for ObservationContext
7b3dc5e 
Relates to spring-projectsgh-2518

Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>
@deejay1 deejay1 mentioned this issue Apr 11, 2025
Closed
TheovanKraay pushed a commit to TheovanKraay/spring-ai that referenced this issue Apr 11, 2025
@ThomasVitale @TheovanKraay
mistral: Adopt new strategy for ObservationContext
72afba6 
Relates to spring-projectsgh-2518

Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>
Signed-off-by: Theo van Kraay <theo.van@microsoft.com>
TheovanKraay pushed a commit to TheovanKraay/spring-ai that referenced this issue Apr 11, 2025
@ThomasVitale @TheovanKraay
ollama: Adopt new strategy for ObservationContext
ae19454 
Relates to spring-projectsgh-2518

Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>
Signed-off-by: Theo van Kraay <theo.van@microsoft.com>
TheovanKraay pushed a commit to TheovanKraay/spring-ai that referenced this issue Apr 11, 2025
@ThomasVitale @TheovanKraay
openai: Adopt new strategy for ObservationContext
478fd5f 
Relates to spring-projectsgh-2518

Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>
Signed-off-by: Theo van Kraay <theo.van@microsoft.com>
@markpollack markpollack added this to the 1.0.0-RC1 milestone Apr 21, 2025
@ilayaperumalg ilayaperumalg mentioned this issue Apr 23, 2025
Open
14 tasks
sobychacko added a commit to sobychacko/spring-ai that referenced this issue Apr 26, 2025
@sobychacko
spring-projectsGH-2518: Remove requestOptions from observation contex…
ffa9cbe 
…t objects

Fixes: spring-projects#2518

Issue: spring-projects#2518

This commit removes the deprecated requestOptions field from ChatModelObservationContext
and EmbeddingModelObservationContext classes. Instead of passing options separately,
the code now retrieves them directly from the request objects (prompt.getOptions() or
embeddingRequest.getOptions()).

Key changes:
- Removed requestOptions parameter from observation context builders
- Updated all model implementations to stop passing options separately
- Fixed EmbeddingRequest handling in several model implementations
- Added buildEmbeddingRequest method in models to properly merge options

This change simplifies the API and removes duplication, as options are already
available in the request objects themselves.

Signed-off-by: Soby Chacko <soby.chacko@broadcom.com>
@sobychacko sobychacko linked a pull request Apr 26, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobychacko sobychacko

Labels
deprecation
Projects
None yet
Milestone
1.0.0-RC1
Development

Successfully merging a pull request may close this issue.

GH-2518: Remove requestOptions from observation context objects sobychacko/spring-ai
3 participants
@markpollack @sobychacko @ThomasVitale