Support function calling for reflection Method with multiple arguments #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KAMO030
added a commit
to KAMO030/spring-ai
that referenced
this pull request
Jul 24, 2024
-- add FunctionCallbackMethodProcessor to support parsing. -- add the FunctionCalling annotation to declare -- add FunctionCallbackMethodProcessorIT as test Dependent on spring-projects#1099
KAMO030
added a commit
to KAMO030/spring-ai
that referenced
this pull request
Jul 24, 2024
-- add FunctionCallbackMethodProcessor to support parsing. -- add the FunctionCalling annotation to declare -- add FunctionCallbackMethodProcessorIT as test Dependent on spring-projects#1099
markpollack
reviewed
Jul 24, 2024
| String className = entry.getKey(); | ||
| Class<?> clazz = entry.getValue(); | ||
|
|
||
| JsonSchema schema = schemaGen.generateSchema(clazz); |
There was a problem hiding this comment.
looking into BeanOutputConverter we could use the following code to reuse the "victools" json schema that I believe is what supports the 2020_12 draft as standard jackson doesn't support that version of the schema. If jackson now supports it, that would be great.
JacksonModule jacksonModule = new JacksonModule();
SchemaGeneratorConfigBuilder configBuilder = new SchemaGeneratorConfigBuilder(DRAFT_2020_12, PLAIN_JSON)
.with(jacksonModule);
SchemaGeneratorConfig config = configBuilder.build();
SchemaGenerator generator = new SchemaGenerator(config);
JsonNode jsonNode = generator.generateSchema(this.typeRef.getType());
... convert node to string..
tzolov
force-pushed
the
function-calling-method-utils
branch
from
f47fe19
to
8d11a01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.