Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Double instead of Float in the portable ChatOptions #1325

Closed
wants to merge 1 commit into from

Conversation

ThomasVitale
Copy link
Contributor

  • The type of the portable chat options (frequencyPenalty, presencePenalty, temperature, topP) has been changed from Float to Double.
  • APIs, test, and documentation have been updated accordingly.

Fixes gh-712

* The type of the portable chat options (frequencyPenalty, presencePenalty, temperature, topP) has been changed from Float to Double.
* APIs, test, and documentation have been updated accordingly.

Fixes spring-projectsgh-712

Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>
@markpollack
Copy link
Member

lots of files, much appreciated.

merged in 4b123a7

@markpollack markpollack modified the milestone: 1.0.0-M3 Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reconsider the Type float/Float in the API
2 participants