feat(core): Add Supplier and Consumer function callback support #1746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzolov
commented
Nov 16, 2024
| return FunctionCallback.builder() | ||
| .description(functionDescription) | ||
| .schemaType(this.schemaType) | ||
| .function(beanName, KotlinDelegate.wrapKotlinSupplier(bean)) |
There was a problem hiding this comment.
Maybe we will need support for the Kotlin's equivalent of java.util.Consumer?
But this can be implemented in a follow up PR.
| @SuppressWarnings("unchecked") | ||
| public static Supplier<?> wrapKotlinSupplier(Object function) { | ||
| return () -> ((Function0<Object>) function).invoke(); | ||
| } |
There was a problem hiding this comment.
Likely we may have to add support for the Kotlin's equivalent of java.util.Consumer() in a follow up PR.
Add support for no-argument Supplier and single-argument Consumer function callbacks in the Spring AI core module. This enhancement allows: - Registration of Supplier<O> callbacks with no input (Void) type - Registration of Consumer<I> callbacks with no output (Void) type - Support for Kotlin Function0 (equivalent to Java Supplier) - Handle empty properties for Void input types in schema generation - Enhance FunctionCallback builder to support Supplier/Consumer patterns Additional changes: - Add test coverage for both Supplier and Consumer callbacks in various scenarios - Enhance TypeResolverHelper to support Consumer input type resolution - Support lambda-style function declarations for improved ergonomics - Add test cases for void input/output handling in OpenAI chat model - Include examples of function calls without return values - Add support for parameterless functions through Supplier interface Resolves spring-projects#1718 , spring-projects#1277 , spring-projects#1118, spring-projects#860
Add comprehensive documentation for the FunctionCallback API in Spring AI, including: - Overview of the interface and its key methods - Builder pattern usage with function and method invocation approaches - Examples for different function types (Function, BiFunction, Supplier, Consumer) - Best practices and common pitfalls - Schema generation and customization options
tzolov
force-pushed
the
support-consumer-supplier-function-calling-v2
branch
from
e7cc220 to
8a32cff
Compare
|
Refactored some of the long methods so that it reads more cleanly. |
|
in the docs, the section "Customization Options" was empty, so I removed it. |
|
merged in 432954d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for no-argument Supplier and single-argument Consumer function callbacks in the Spring AI core module. This enhancement allows:
Additional changes:
Resolves #1718 , #1277 , #1118, #860