Cassandra Chat Memory: Fixed message order #2839
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Linar Abzaltdinov <abzaltdinov@gmail.com>
Signed-off-by: Linar Abzaltdinov <abzaltdinov@gmail.com>
…ontainer by actual one Signed-off-by: Linar Abzaltdinov <abzaltdinov@gmail.com>
|
@michaelsembwever @tzolov As main contributor/reviewer of CassandraChatMemory feature, could you please take a look at this PR? |
|
|
||
| import java.time.Duration; | ||
| import java.util.List; | ||
| import java.util.UUID; |
There was a problem hiding this comment.
is it correct to move import java… down to here ?
There was a problem hiding this comment.
Well, that's how Intellij IDEA orders imports by default.
Didn't know about code style guide of Spring projects.
Reordered as it described in https://github.com/spring-projects/spring-framework/wiki/Code-Style
michaelsembwever
approved these changes
Apr 23, 2025
Signed-off-by: Linar Abzaltdinov <abzaltdinov@gmail.com>
Closed
deejay1
approved these changes
Apr 24, 2025
|
@linarkou thanks so much for your contribution! I'd like to reference here the comment I left on the similar PR for JDBC about the new APIs and changes we have just delivered for chat memory: #2781 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #2815
This PR solves problem with message ordering:
CassandraChatMemory fetches rows in DESC order (by message_timestamp), and MessageChatMemoryAdvisor get and add all messages in that order - from last to first. So messages list needs to be reversed.
Same problem of JDBC Chat Memory solved here #2781