Add Azure OpenAI Chat and Embedding Options #286
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tzolov
commented
Jan 30, 2024
tzolov
commented
- Add AzureOpenAiChatOptions
- Add default options field to AzureOpenAiChatClient.
- Impl runtime (e.g. prompt) and default options on call.
- Add options field to the AzureOpenAiChatProperties.
- Add AzureOpenAiEmbeddingOptions
- Add default options field to AzureOpenAiEmbeddingClient.
- Implement runtime and default option merging on embedding request.
- Add options field to AzureOpenAiEmbeddingProperties.
- Add Unit and ITs.
- Split the azure-openai.adoc into ./clients/azure-openai-chat.adoc and ./embeddings/azure-openai-embeddings.adoc.
- Provide detailed explanation how to use the chat and embedding clients manually or via the auto-configuration.
tzolov
force-pushed
the
add-azure-chat-embedding-options
branch
from
4b88b5c
to
c2dbc31
Compare
tzolov
force-pushed
the
add-azure-chat-embedding-options
branch
2 times, most recently
from
fe7ebf8
to
8c99ea3
Compare
- Add AzureOpenAiChatOptions - Add default options field to AzureOpenAiChatClient. - Impl runtime (e.g. prompt) and default options on call. - Add options field to the AzureOpenAiChatProperties. - Add AzureOpenAiEmbeddingOptions - Add default options field to AzureOpenAiEmbeddingClient. - Impmlement runtime and default option merging on embedding request. - Add options field to AzureOpenAiEmbeddingProperties. - Add Unit and ITs. - Split the azure-openai.adoc into ./clients/azure-openai-chat.adoc and ./embeddings/azure-openai-embeddings.adoc. - Provide detailed explanation how to use the chat and embedding clients manually or via the auto-configuration.
tzolov
force-pushed
the
add-azure-chat-embedding-options
branch
from
8c99ea3
to
2470f54
Compare
|
review this in the context of #10 |
markpollack
reviewed
Feb 5, 2024
| @@ -1,78 +1,9 @@ | |||
| # 1. Azure OpenAI | |||
| # Azure OpenAI | |||
There was a problem hiding this comment.
why not remove this readme... docs should be centralized.
| mergedAzureOptions.setTemperature(azureOptions.getTemperature()); | ||
| if (mergedAzureOptions.getTemperature() == null && springAiOptions.getTemperature() != null) { | ||
| mergedAzureOptions.setTemperature(springAiOptions.getTemperature().doubleValue()); | ||
| } |
There was a problem hiding this comment.
Why have if (mergedAzureOptions.getTemperature() == null && springAiOptions.getTemperature() != null) {
instead of if (mergedAzureOptions.getTemperature() == null as in the other cases?
Also we don't need to call doubleValue() in mergedAzureOptions.setTemperature(springAiOptions.getTemperature().doubleValue()); as it accepts the wrapper number type directly.
|
merged as dfbea8c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.