Make BedrockAwsConnectionProperties#region empty by default
#3225
+16
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@therepanic Thanks for the PR! Could you update the documentation for the change (removing the default)? |
|
Thanks, @ilayaperumalg. Sorry, I accidentally formatted the wrong changes and closed the PR. I changed the documentation of the region field (to make it clear that if it is empty, Also, I have now specified the region in the tests to make the tests pass. Everything should be fine now. |
|
@therepanic No problem at all, thank you for the quick follow up! |
…-projects#3223) Signed-off-by: Andrey Litvitski <andrey1010102008@gmail.com>
|
I forgot to use |
|
@ashakirin what do you think? |
|
Mind, that removing the default region is a breaking change. It has to come at 1.1.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If our region is empty, then
DefaultAwsRegionProviderChainwill be used, which will search for the region in every possible way. This should be better for us, instead of setting the default field ourselves.Resolves: #3223