fix: VertixAiEmbeddingConnectionDetails not injected when using spring-ai-starter-model-vertex-ai-embedding #4801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x-ai-embedding starter Signed-off-by: Nguyen Tran (Mark) <nguyen.trantrung@navercorp.com>
nguyen-trantrung
force-pushed
the
issues/4800
branch
from
76e110c to
fed6eca
Compare
ilayaperumalg
approved these changes
Nov 5, 2025
ilayaperumalg
approved these changes
Nov 5, 2025
Member
|
@nguyen-trantrung Thanks once again for the fix. Rebased, fixed the check style issue and merged as 9de3592 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for taking time to contribute this pull request!
You might have already read the contributor guide, but as a reminder, please make sure to:
git commit -s) per the DCOmainbranch and squash your commitsFor more details, please check the contributor guide.
Thank you upfront!
Related: #4800