GH-2456: Suppress Duplicate Annotations with Spy #2457
Conversation
Resolves spring-projects#2456 When spying a `@RabbitListener` bean, duplicate methods are resolved as well as duplicate class level `@RabbitListener` annotations. **cherry-pick to 2.4.x** (will require instanceof polishing for Java 8)
|
does this confirm that premise of the Thanks |
|
Yes, that's why I added the I couldn't detect any difference at runtime - the mock method is still in the stack trace (set a breakpoint in This doesn't actually make any difference to the spy, it just avoids us finding both sets of annotations which causes duplicate containers/methods. |
|
... and cherry-picked to |
| @@ -339,7 +339,8 @@ private TypeMetadata buildMetadata(Class<?> targetClass) { | |||
| multiMethods.add(method); | |||
| } | |||
| } | |||
| }, ReflectionUtils.USER_DECLARED_METHODS); | |||
| }, ReflectionUtils.USER_DECLARED_METHODS | |||
| .and(meth -> !meth.getDeclaringClass().getName().contains("$MockitoMock$"))); | |||
There was a problem hiding this comment.
cherry-picked to 2.4.x breaks compatibility with Spring Framework 5.2, USER_DECLARED_METHODS comes with a and method only after 5.3.2
There was a problem hiding this comment.
Spring Framework 5.2.x is no longer supported as OSS and goes out of commercial support at the end of the year.
https://spring.io/projects/spring-framework#support
However, 2.4.x has always used Spring Framework 5.3.x; it has never supported being run on 5.2.x. Here is the version on the v2.4.0 tag:
Line 66 in 6235c7b
It currently requires 5.3.30.
There was a problem hiding this comment.
But the reference said it works with 5.2.x.
And in fact, everything else looks good with 5.2.x
There was a problem hiding this comment.
That's a bug in the documentation but, in any case, as I said 5.2.x is out of support anyway.
There was a problem hiding this comment.
I made an exception and made the change dcc49ba
The next release is mid-October.
But I still recommend that you move to a supported version of Spring Framework.
There was a problem hiding this comment.
Thank you! I'd like to upgrade, but it's out of my control.
Resolves #2456
When spying a
@RabbitListenerbean, duplicate methods are resolved as well as duplicate class level@RabbitListenerannotations.cherry-pick to 2.4.x (will require instanceof polishing for Java 8)