Add a reproducer for spring-projects/spring-framework#31050 #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The related error happen with Hibernate 6.2 with custom find methods on non-transactional use cases.
sdeleuze
added a commit
to sdeleuze/spring-framework
that referenced
this pull request
Aug 16, 2023
This commit contributes proxy hints needed by SharedEntityManagerCreator for org.hibernate.query.sqm.internal.QuerySqmImpl interfaces. Until Hibernate 6.1, those hints were erroneously provided at GraalVM reachability metadata level. As of Hibernate 6.2, they are not, hence the need to contribute them at Spring Framework level. A related smoke test has been contributed via spring-projects/spring-aot-smoke-tests#188. Closes spring-projectsgh-31050
|
LGTM. I'll merge it as soon as SF 6.0.12 is released. |
mhalbritter
approved these changes
Aug 17, 2023
|
I added a reproducer for spring-projects/spring-framework#29603 as well. |
sdeleuze
added a commit
to sdeleuze/spring-framework
that referenced
this pull request
Aug 18, 2023
This commit contributes proxy hints needed by SharedEntityManagerCreator for org.hibernate.query.sql.internal.NativeQueryImpl interfaces. A related smoke test has been contributed via spring-projects/spring-aot-smoke-tests#188. Closes spring-projectsgh-29603
wilkinsona
pushed a commit
that referenced
this pull request
Sep 21, 2023
The related error happen with Hibernate 6.2 with custom find methods on non-transactional use cases. See gh-188
wilkinsona
pushed a commit
that referenced
this pull request
Sep 21, 2023
|
Thanks, @sdeleuze. I've merged this into both 3.0.x and main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The related error happen with Hibernate 6.2 with custom find methods on non-transactional use cases.
See spring-projects/spring-framework#31050 for more details.
@mhalbritter Up to you to decide if you merge it now or if you wait Spring Framework 6.0.12 which will contains the fix.