Skip to content

fix: error description not url-encoded #1078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Edsuns
Copy link

@Edsuns Edsuns commented Feb 19, 2023

error.getDescription() is not encoded here:

That will cause IllegalArgumentException below:

java.lang.IllegalArgumentException: Invalid character ' ' for QUERY_PARAM in "OAuth 2.0 Parameter: client_id"
	at org.springframework.web.util.HierarchicalUriComponents.verifyUriComponent(HierarchicalUriComponents.java:421) ~[spring-web-6.0.2.jar:6.0.2]
	at org.springframework.web.util.HierarchicalUriComponents.lambda$verify$4(HierarchicalUriComponents.java:389) ~[spring-web-6.0.2.jar:6.0.2]
	at org.springframework.util.UnmodifiableMultiValueMap.lambda$forEach$0(UnmodifiableMultiValueMap.java:114) ~[spring-core-6.0.2.jar:6.0.2]
	at java.base/java.util.Map.forEach(Map.java:713) ~[na:na]

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 19, 2023
@jgrandja
Copy link
Collaborator

Thank you for reporting this @Edsuns. I completely missed the encoding of the OAuth2Error while applying polish to gh-1011. Luckily, I was able to apply the updates via 0cd5940 just before the releases today. Thanks again for the quick feedback! I will close this as a duplicate.

@jgrandja jgrandja closed this Feb 21, 2023
@jgrandja jgrandja self-assigned this Feb 21, 2023
@jgrandja jgrandja added status: duplicate A duplicate of another issue and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate A duplicate of another issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants