Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Gradle deprecation warnings #645

Conversation

VonUniGE
Copy link

@VonUniGE VonUniGE commented Mar 13, 2022

Running:

 ./gradlew build --warning-mode all

shows deprecation warnings which will become fatal errors with Gradle 7.

This PR replaces:

  • compile by implementation(or api when needed),
  • testCompile by testImplementation,
  • testRuntime by testRuntimeOnly.

This solves partly issue #572, which is still blocked by spring-gradle-plugins/spring-build-conventions#95.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 13, 2022
@jgrandja
Copy link
Collaborator

Thanks for the PR @VonUniGE.

As mentioned in this comment, we are planning on upgrading to Gradle 7 for next release.

The updates in this PR is a small subset of changes required to make the upgrade. I'll leave this open for now as @sjohnr will be working on the upgrade and will follow up with you at a later point.

@jgrandja jgrandja added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 25, 2022
@sjohnr
Copy link
Member

sjohnr commented Apr 19, 2022

Thanks for the PR @VonUniGE! As @jgrandja mentioned, this work was covered by #572 so I'll close this as a duplicate.

@sjohnr sjohnr closed this Apr 19, 2022
@sjohnr sjohnr added status: duplicate A duplicate of another issue and removed type: enhancement A general enhancement labels Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate A duplicate of another issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants