Skip to content

Missing information about error handling in ChunkListeners #4384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fmbenhassine opened this issue May 24, 2023 · 1 comment
Closed

Missing information about error handling in ChunkListeners #4384

fmbenhassine opened this issue May 24, 2023 · 1 comment

Comments

@fmbenhassine
Copy link
Contributor

Chunk listeners are not designed to throw exceptions. Exceptions must be handled in the implementation or the step will terminate. This is mentioned in the javadoc of TerminateOnExceptionChunkListenerDelegate, but this class is private.

The section about ChunkListeners in the reference documentation should be updated with this important detail.


References:

@injae-kim
Copy link
Contributor

Hi @fmbenhassine ! to resolve this issue, I made PR #4490 with proper unit test.
Can you simply check my PR? thanks! 🙇

@fmbenhassine fmbenhassine added this to the 5.2.0-M1 milestone Apr 30, 2024
natedanner pushed a commit to natedanner/spring-projects__spring-batch that referenced this issue May 20, 2024
FBibonne pushed a commit to FBibonne/spring-batch that referenced this issue Feb 2, 2025
Resolves spring-projects#4384

Signed-off-by: Fabrice Bibonne <fabrice.bibonne@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants