Skip to content

Wrong column types in JdbcStepExecutionDao #4648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
v00d00c0de opened this issue Aug 18, 2024 · 3 comments
Closed

Wrong column types in JdbcStepExecutionDao #4648

v00d00c0de opened this issue Aug 18, 2024 · 3 comments
Labels
for: backport-to-5.1.x Issues that will be back-ported to the 5.1.x line in: core type: bug
Milestone

Comments

@v00d00c0de
Copy link

In 5.0, StepExecution's 'int' fields were updated to 'long'.
JdbcStepExecutionDao::buildStepExecutionParameters was changed accordingly to use Types.BIGINT for such fields, but not JdbcStepExecutionDao::updateStepExecution.

new int[] { Types.TIMESTAMP, Types.TIMESTAMP, Types.VARCHAR, Types.INTEGER, Types.INTEGER,

@fmbenhassine
Copy link
Contributor

That's correct, thank you for raising this!

The row mapper should also be updated to get values as long from the result set here:

I will plan the fix for the next release.

@fmbenhassine fmbenhassine added type: bug in: core for: backport-to-5.1.x Issues that will be back-ported to the 5.1.x line labels Sep 3, 2024
@fmbenhassine fmbenhassine added this to the 5.2.0-RC1 milestone Sep 3, 2024
@hyejinggu
Copy link
Contributor

Is this issue still open for progress? I would like to know if I can go ahead and create a pull request to resolve it.

@fmbenhassine
Copy link
Contributor

@hyejinggu You are welcome to contribute a PR. Thank you for your offer to help!

@fmbenhassine fmbenhassine changed the title StepExecution: update via JdbcStepExecutionDao has wrong column types Wrong column types in JdbcStepExecutionDao Oct 22, 2024
fmbenhassine pushed a commit that referenced this issue Oct 22, 2024
FBibonne pushed a commit to FBibonne/spring-batch that referenced this issue Feb 2, 2025
Resolves spring-projects#4648

Signed-off-by: Fabrice Bibonne <fabrice.bibonne@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: backport-to-5.1.x Issues that will be back-ported to the 5.1.x line in: core type: bug
Projects
None yet
Development

No branches or pull requests

3 participants