BATCH-1509 #1
Closed
BATCH-1509 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 2, 2010 01:28
|
The new parser looks OK. I didn't test it because the test code is a main() (not a unit test) and it uses a tcp connection to a database that I don't have. Can you remove the sandbox stuff and replace it with a test in or alongside PartitionStepParserTests? If you want something like the sandboc code to survive, look at the _Partition_Tests in spring-batch-samples and copy one of those (use the same domain model and database). |
…ta lines even though the row should be skipped
|
Josh, I'm confused. You have two pull requests now for the same branch? And this one is for a bug that was already resolved (BATCH-1509)? Plus the sandbox stuff is still there? Or I'm not getting something... |
This was referenced Dec 16, 2019
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please consider part of this request for inclusion as a candidate to fix BATCH-1509; id generally appreciate any feedback