Skip to content

Proposal for BATCH-1674 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

snicoll
Copy link
Member

@snicoll snicoll commented Dec 24, 2010

Candidate fix for BATCH-1674

@dsyer
Copy link
Member

dsyer commented Dec 27, 2010

Stephane, thanks for the suggestion. Which dependencies actually require these repositories?

I'm not sure if this is the best solution because in principle we want to keep repository declarations out of the public poms in Maven Central (best practice for public libraries). I could imagine maybe adding the declarations to a profile. Maybe we could figure out a way to change the profile activation when the pom is deployed? (In fact I'm not sure there isn't already a "bootstrap" profile with repository declarations in it - I agree that it is nice to build out of the box, so activation is something I would like to hear your views on.)

@snicoll
Copy link
Member Author

snicoll commented Dec 27, 2010

From what I recall, one repository was necessary for the springsource's bundler plugin. The other repository was needed for the tool you use to generate SQL files (vpp or something).

Agreed, repository declarations should go out of the public pom because once they are in, they affect how Maven resolve all dependencies for the project. Central currently rejects poms containing such repositories definition.

I would go for

  1. a profile that you could activate if needed
  2. a page on the website declaring the repositories you want. I had to search a bit to find them

There is no nice way to handle this issue at the moment as far as I know.

@dsyer
Copy link
Member

dsyer commented Feb 7, 2011

You can use -P bootstrap as per the instructions: http://static.springsource.org/spring-batch/building.html. Does that not work? I don't think we can do much better.

@snicoll
Copy link
Member Author

snicoll commented Feb 12, 2011

yep, I agree.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants