Fix SystemCommandTasklet to propagate error when exit status is failed #4566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
injae-kim
commented
Mar 12, 2024
| RepeatStatus exitStatus = tasklet.execute(stepContribution, null); | ||
|
|
||
| assertEquals(RepeatStatus.FINISHED, exitStatus); | ||
| assertEquals(ExitStatus.FAILED, stepContribution.getExitStatus()); |
There was a problem hiding this comment.
AssertionFailed
Expected :exitCode=FAILED;exitDescription=
Actual :exitCode=EXECUTING;exitDescription=With L329, this test failed so I just remove it.
Should we set contribution.setExitStatus(FAILED); on SystemCommandTasklet L128?
There was a problem hiding this comment.
Yes, we need to update the contribution's exit status in both cases.
There was a problem hiding this comment.
✅ updated! thank you :)
|
Thank you for the update. LGTM now 👍 Rebased, squashed and merged as 692e769. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4483.
Motivation
SystemCommandTaskletdoes not propagate errors when command returns anon-zeroexit code, which is mapped toExistStatus.FAILEDModification
SystemCommandTaskletto propagate error whenExistStatus.FAILED