Use Threadlocal.remove() instead of Threadlocal.set(null) #4601
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Team,
This PR improves memory management by replacing instances of
ThreadLocal.set(null)
withThreadLocal.remove()
and removing the unnecessaryThreadLocal.set(null)
in the constructor.In the current implementation,
ThreadLocal.set(null)
is used to clear theThreadLocal
variable. This approach can leave theThreadLocal
variable in the thread's local variable map with a null value, potentially causing memory leaks. UsingThreadLocal.remove()
instead properly removes theThreadLocal
variable from the thread's local variable map, preventing memory leaks.Additionally, the constructor for
JobFlowExecutor
contains an unnecessaryThreadLocal.set(null)
, which is redundant because theThreadLocal
variable is already initialized tonull
by default.