Fix variable usage in ScriptItemProcessorTests and include script engine test dependencies #4678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor to use local variables instead of global variables in testJRubyScriptSourceSimple,testJRubyScriptSourceMethod
|
That's great, thank you for your contribution! I tested the changes and they LGTM 👍 Can you please squash your commits and extract the versions of newly added test dependencies as properties? Other than that, it should be good to merge. |
fmbenhassine
added
the
status: waiting-for-reporter
|
Rebased, squashed and merged as 6961571. Thank you for your contribution! |
fmbenhassine
removed
the
status: waiting-for-reporter
fmbenhassine
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added script engine dependencies for Groovy, JavaScript, Bash, and Ruby in ScriptItemProcessor tests.
Fixed a script error in the Ruby test by refactoring the script to use local variables instead of global variables.
related post