fix for BATCH-1691 allow to define groupBy for SqlPagingQueryProviderFactoryBean #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch. I can't see any tests. Did you forget to push them? |
|
sorry, I added tests for the group by clause I did not check the SqlWindowingPagingQueryProvider stuff (ROWID and TOP statements) on a real database |
|
OK, thanks. I think it is broken based on initial quick testing. I'll take a look when I've got time. If you have time yourself you could add a test or two to the spring-batch-infrastructure-tests project (there's already an integration test for JDBC paging). |
Conflicts: archetypes/pom.xml archetypes/simple-cli/pom.xml pom.xml spring-batch-core-tests/pom.xml spring-batch-core/pom.xml spring-batch-infrastructure-tests/pom.xml spring-batch-infrastructure/pom.xml spring-batch-parent/pom.xml spring-batch-samples/pom.xml spring-batch-test/pom.xml
bclozel
pushed a commit
to bclozel/spring-batch
that referenced
this pull request
Jun 23, 2014
Make the link to a project's forum optional
This was referenced Dec 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.