Optimize logger calls

Guard logger calls to ensure that they are only made when the
level is set.

See gh-18710

Author: wycm

spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/metrics/jdbc/DataSourcePoolMetricsAutoConfiguration.java

@@ -124,7 +124,9 @@ private void bindMetricsRegistryToHikariDataSource(HikariDataSource hikari) {
 					hikari.setMetricsTrackerFactory(new MicrometerMetricsTrackerFactory(this.registry));
 				}
 				catch (Exception ex) {
-					logger.warn("Failed to bind Hikari metrics: " + ex.getMessage());
+					if (logger.isWarnEnabled()) {
+						logger.warn("Failed to bind Hikari metrics: " + ex.getMessage());
+					}
 				}
 			}
 		}

spring-boot-project/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/system/DiskSpaceHealthIndicator.java

@@ -62,8 +62,10 @@ protected void doHealthCheck(Health.Builder builder) throws Exception {
 			builder.up();
 		}
 		else {
-			logger.warn(String.format("Free disk space below threshold. Available: %d bytes (threshold: %s)",
-					diskFreeInBytes, this.threshold));
+			if (logger.isWarnEnabled()) {
+				logger.warn(String.format("Free disk space below threshold. Available: %d bytes (threshold: %s)",
+						diskFreeInBytes, this.threshold));
+			}
 			builder.down();
 		}
 		builder.withDetail("total", this.path.getTotalSpace()).withDetail("free", diskFreeInBytes)

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/data/neo4j/Neo4jDataAutoConfiguration.java

@@ -111,7 +111,7 @@ static class Neo4jWebConfiguration {
 
 		@Bean
 		OpenSessionInViewInterceptor neo4jOpenSessionInViewInterceptor(Neo4jProperties properties) {
-			if (properties.getOpenInView() == null) {
+			if (properties.getOpenInView() == null && logger.isWarnEnabled()) {
 				logger.warn("spring.data.neo4j.open-in-view is enabled by default."
 						+ "Therefore, database queries may be performed during view "
 						+ "rendering. Explicitly configure "

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/groovy/template/GroovyTemplateAutoConfiguration.java

@@ -83,7 +83,7 @@ public GroovyMarkupConfiguration(ApplicationContext applicationContext, GroovyTe
 		public void checkTemplateLocationExists() {
 			if (this.properties.isCheckTemplateLocation() && !isUsingGroovyAllJar()) {
 				TemplateLocation location = new TemplateLocation(this.properties.getResourceLoaderPath());
-				if (!location.exists(this.applicationContext)) {
+				if (!location.exists(this.applicationContext) && logger.isWarnEnabled()) {
 					logger.warn("Cannot find template location: " + location
 							+ " (please add some templates, check your Groovy "
 							+ "configuration, or set spring.groovy.template.check-template-location=false)");

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jackson/JacksonAutoConfiguration.java

@@ -119,8 +119,10 @@ static class JodaDateTimeJacksonConfiguration {
 
 		@Bean
 		SimpleModule jodaDateTimeSerializationModule(JacksonProperties jacksonProperties) {
-			logger.warn("Auto-configuration of Jackson's Joda-Time integration is deprecated in favor of using "
-					+ "java.time (JSR-310).");
+			if (logger.isWarnEnabled()) {
+				logger.warn("Auto-configuration of Jackson's Joda-Time integration is deprecated in favor of using "
+						+ "java.time (JSR-310).");
+			}
 			SimpleModule module = new SimpleModule();
 			JacksonJodaDateFormat jacksonJodaFormat = getJacksonJodaDateFormat(jacksonProperties);
 			if (jacksonJodaFormat != null) {

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jdbc/DataSourceInitializerInvoker.java

@@ -76,7 +76,9 @@ private void initialize(DataSourceInitializer initializer) {
 			}
 		}
 		catch (IllegalStateException ex) {
-			logger.warn("Could not send event to complete DataSource initialization (" + ex.getMessage() + ")");
+			if (logger.isWarnEnabled()) {
+				logger.warn("Could not send event to complete DataSource initialization (" + ex.getMessage() + ")");
+			}
 		}
 	}
 

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/mustache/MustacheAutoConfiguration.java

@@ -63,7 +63,7 @@ public MustacheAutoConfiguration(MustacheProperties mustache, ApplicationContext
 	public void checkTemplateLocationExists() {
 		if (this.mustache.isCheckTemplateLocation()) {
 			TemplateLocation location = new TemplateLocation(this.mustache.getPrefix());
-			if (!location.exists(this.applicationContext)) {
+			if (!location.exists(this.applicationContext) && logger.isWarnEnabled()) {
 				logger.warn("Cannot find template location: " + location
 						+ " (please add some templates, check your Mustache configuration, or set spring.mustache."
 						+ "check-template-location=false)");

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/orm/jpa/JpaBaseConfiguration.java

@@ -216,7 +216,7 @@ protected JpaWebConfiguration(JpaProperties jpaProperties) {
 
 		@Bean
 		public OpenEntityManagerInViewInterceptor openEntityManagerInViewInterceptor() {
-			if (this.jpaProperties.getOpenInView() == null) {
+			if (this.jpaProperties.getOpenInView() == null && logger.isWarnEnabled()) {
 				logger.warn("spring.jpa.open-in-view is enabled by default. "
 						+ "Therefore, database queries may be performed during view "
 						+ "rendering. Explicitly configure spring.jpa.open-in-view to disable this warning");

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/web/reactive/error/AbstractErrorWebExceptionHandler.java

@@ -287,7 +287,7 @@ protected void logError(ServerRequest request, ServerResponse response, Throwabl
 			logger.debug(request.exchange().getLogPrefix() + formatError(throwable, request));
 		}
 		if (HttpStatus.resolve(response.rawStatusCode()) != null
-				&& response.statusCode().equals(HttpStatus.INTERNAL_SERVER_ERROR)) {
+				&& response.statusCode().equals(HttpStatus.INTERNAL_SERVER_ERROR) && logger.isErrorEnabled()) {
 			logger.error(request.exchange().getLogPrefix() + "500 Server Error for " + formatRequest(request),
 					throwable);
 		}

spring-boot-project/spring-boot-devtools/src/main/java/org/springframework/boot/devtools/autoconfigure/OptionalLiveReloadServer.java

@@ -54,7 +54,9 @@ void startServer() throws Exception {
 				if (!this.server.isStarted()) {
 					this.server.start();
 				}
-				logger.info("LiveReload server is running on port " + this.server.getPort());
+				if (logger.isInfoEnabled()) {
+					logger.info("LiveReload server is running on port " + this.server.getPort());
+				}
 			}
 			catch (Exception ex) {
 				logger.warn("Unable to start LiveReload server");