Skip to content

Optimization log #18710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Optimization log #18710

wants to merge 3 commits into from

Conversation

@wycm
Copy link

@wycm wycm commented Oct 23, 2019

Optimization log

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 23, 2019
@philwebb
Copy link
Member

philwebb commented Oct 23, 2019

Thanks for the PR but I'm not sure we should apply all of these. Some of these log statements happen quite infrequently and as such don't need optimizations. I'll assign this to 2.2.x and we can take a look in more detail before we merge.

@philwebb philwebb added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 23, 2019
@philwebb philwebb added this to the 2.2.x milestone Oct 23, 2019
philwebb pushed a commit that referenced this pull request Oct 24, 2019
@philwebb
Optimize logger calls
240b1f9 
Guard logger calls to ensure that they are only made when the
level is set.

See gh-18710
philwebb added a commit that referenced this pull request Oct 24, 2019
@philwebb
Polish "Optimize logger calls"
597baf9 
See gh-18710
@philwebb philwebb closed this in f3dcf10 Oct 24, 2019
@philwebb
Copy link
Member

philwebb commented Oct 24, 2019

Thanks for finding these @wycm. I've polished things a bit in commit 597baf9 mainly by making use of Spring Frameworks new LogMessage class. I've also remove a few if statements where the log message was a simple String so relatively cheap.

Thanks again!

@philwebb philwebb modified the milestones: 2.2.x, 2.2.1 Oct 24, 2019
@wilkinsona wilkinsona reopened this Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

type: task A general task

Projects

None yet

Milestone

2.2.1

Development

Successfully merging this pull request may close these issues.

4 participants

@wycm @philwebb @wilkinsona @spring-projects-issues