Skip to content

Commit

Permalink
Restore lazy evaluation of project/build/finalName
Browse files Browse the repository at this point in the history
This commit restores the read-only `finalName` so that its value can
be lazily resolved against `${project.build.finalName}`.

While doing the evaluation ourselves and not relying on a dedicated
field at all would have been better, the evaluation increased the
number of required dependencies for no good reason.

IDEs should not offer auto-completion for that read-only field and it
is not published in the generated site either.

Closes gh-16456
  • Loading branch information
snicoll committed May 13, 2019
1 parent 00b2954 commit 4c1ef63
Showing 1 changed file with 1 addition and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -266,8 +266,7 @@ private File getTargetFile() {
if (!this.outputDirectory.exists()) {
this.outputDirectory.mkdirs();
}
String finalName = this.project.getBuild().getFinalName();
return new File(this.outputDirectory, finalName + classifier + "."
return new File(this.outputDirectory, this.finalName + classifier + "."
+ this.project.getArtifact().getArtifactHandler().getExtension());
}

Expand Down

0 comments on commit 4c1ef63

Please sign in to comment.