Attempt to fix Windows build failure due to open files

See gh-38204
spring-projects · Nov 8, 2023 · dbbde18 · dbbde18
1 parent f9c9f32
commit dbbde18
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 5 deletions.
diff --git a/...src/test/java/org/springframework/boot/loader/net/protocol/jar/JarUrlConnectionTests.java b/...src/test/java/org/springframework/boot/loader/net/protocol/jar/JarUrlConnectionTests.java
@@ -502,8 +502,14 @@ void getLastModifiedReturnsFileModifiedTime() throws Exception {
 	void getLastModifiedHeaderReturnsFileModifiedTime() throws IOException {
 		JarUrlConnection connection = JarUrlConnection.open(this.url);
 		URLConnection fileConnection = this.file.toURI().toURL().openConnection();
-		assertThat(connection.getHeaderFieldDate("last-modified", 0)).isEqualTo(withoutNanos(this.file.lastModified()))
-			.isEqualTo(fileConnection.getHeaderFieldDate("last-modified", 0));
+		try {
+			assertThat(connection.getHeaderFieldDate("last-modified", 0))
+				.isEqualTo(withoutNanos(this.file.lastModified()))
+				.isEqualTo(fileConnection.getHeaderFieldDate("last-modified", 0));
+		}
+		finally {
+			fileConnection.getInputStream().close();
+		}
 	}
 
 	private long withoutNanos(long epochMilli) {

diff --git a/...st/java/org/springframework/boot/loader/net/protocol/nested/NestedUrlConnectionTests.java b/...st/java/org/springframework/boot/loader/net/protocol/nested/NestedUrlConnectionTests.java
@@ -162,9 +162,14 @@ void getLastModifiedReturnsFileModifiedTime() throws Exception {
 	void getLastModifiedHeaderReturnsFileModifiedTime() throws IOException {
 		NestedUrlConnection connection = new NestedUrlConnection(this.url);
 		URLConnection fileConnection = this.jarFile.toURI().toURL().openConnection();
-		assertThat(connection.getHeaderFieldDate("last-modified", 0))
-			.isEqualTo(withoutNanos(this.jarFile.lastModified()))
-			.isEqualTo(fileConnection.getHeaderFieldDate("last-modified", 0));
+		try {
+			assertThat(connection.getHeaderFieldDate("last-modified", 0))
+				.isEqualTo(withoutNanos(this.jarFile.lastModified()))
+				.isEqualTo(fileConnection.getHeaderFieldDate("last-modified", 0));
+		}
+		finally {
+			fileConnection.getInputStream().close();
+		}
 	}
 
 	private long withoutNanos(long epochMilli) {