Skip to content

Log summary of exposed web endpoints at startup #12442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wilkinsona opened this issue Mar 12, 2018 · 4 comments
Closed

Log summary of exposed web endpoints at startup #12442

wilkinsona opened this issue Mar 12, 2018 · 4 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@wilkinsona
Copy link
Member

Unlike Spring MVC and Spring WebFlux, Jersey doesn't log its request mappings. A side-effect of this is that when you use the Actuator on top of Jersey all of the endpoints disappear from the log. The argument in favour of the current arrangement is that it aligns with Jersey's behaviour and might be part of the reason why a user prefers Jersey. The argument against the current arrangement is that users who are used to a Spring MVC or WebFlux-based Actuator may get confused and think the endpoints aren't working.

@wilkinsona wilkinsona added type: enhancement A general enhancement for: team-attention An issue we'd like other members of the team to review priority: normal labels Mar 12, 2018
@snicoll
Copy link
Member

snicoll commented Mar 12, 2018

The argument against the current arrangement is that users who are used to a Spring MVC or WebFlux-based Actuator may get confused and think the endpoints aren't working.

Whatever we do, we'll need to draw a line somewhere as there are many other differences between Jersey and Spring MVC. I think the two systems are different and relying on log output for this is weird. Perhaps that's the problem and we should offer something that provides that information?

@philwebb
Copy link
Member

How about we add our own log for "Exposing {number} actuator web endpoints under {rootpath}" that's consistently used for MVC, WebFlux and Jersey?

@snicoll
Copy link
Member

snicoll commented Mar 12, 2018

Phil's idea gets my vote

@wilkinsona
Copy link
Member Author

Sounds good to me too.

@wilkinsona wilkinsona self-assigned this Mar 12, 2018
@wilkinsona wilkinsona removed the for: team-attention An issue we'd like other members of the team to review label Mar 12, 2018
@wilkinsona wilkinsona added this to the 2.0.1 milestone Mar 12, 2018
@wilkinsona wilkinsona changed the title Consider logging Actuator endpoint mappings when using Jersey Log summary of exposed web endpoints at startup Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants