Health indicators have ambiguous keys

[tkruse]

Hi,
invoking the health actuator, I got this response:
{"status":"UP","version":"2.4.8"}

It would be nice if there was slightly more information here by default, such as what the version belongs to (in my case mongodb version).

[cdupuis]

That looks odd indeed. I assume you only have the MongoHealthIndicator active in your app. I look at adding some sort of key or identifier.

[snicoll]

👍 I think the output structure should be similar if we have one HealthIndicator or many.

[dsyer]

I'm not sure that I agree entirely - if there is only one HealthIndicator then I don't need to see an array with one item in it. It would be good to know what type of indicator it is that has that version field (e.g. just add "type":"mongodb" to the object).

[cdupuis]

@dsyer right now we the following structure when more then one HealthIndicator is registered:

{
  "status" : "UP",
  "ic" : {
    "status" : "UP",
    "version" : "ICEthS1-2.0.197"
  },
  "mongo" : {
    "status" : "UP",
    "version" : "2.4.8"
  }
}

and the following with only one: {"status":"UP","version":"2.4.8"}

So with the proposed change this would change to:

{
  "status" : "UP",
  "ic" : {
    "status" : "UP",
    "version" : "ICEthS1-2.0.197"
  }
}

I think that would be consistent.

[tkruse]

In case that the information is going to be processesd by a machine, I believe it would be good to have the same structure regardless of whether there is one entry or many. That way, if you start with one Indicator, write a parsing script, and later add a second one, your parsing script will still work. Same for removing an indicator down to one. Parsing the result should stay as robust as possible.

[cdupuis]

@tkruse I agree.

[philwebb]

This change has broken the spring-boot-sample-actuator-ui tests

[philwebb]

It returns {"status":"UP"[,"status":{"status":"UP"}]}