Skip to content

Rename VanillaPublicMetrics to ApplicationPublicMetrics #1366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
snicoll opened this issue Aug 12, 2014 · 1 comment
Closed

Rename VanillaPublicMetrics to ApplicationPublicMetrics #1366

snicoll opened this issue Aug 12, 2014 · 1 comment
Labels
status: invalid An issue that we don't feel is valid

Comments

@snicoll
Copy link
Member

snicoll commented Aug 12, 2014

@philwebb updated VanillaHealthIndicator to ApplicationHealthIndicator in 7d0a3dd (#1291)

It looks like VanillaPublicMetrics should be renamed as well, at least for consistency. Besides, that class became more the "default" implementation that looks for any implementation in the classpath to merge all the public metrics.
@philwebb philwebb added this to the 1.2.0 milestone Aug 12, 2014
@snicoll
Copy link
Member Author

snicoll commented Aug 25, 2014

Actually @philwebb did refactor the changes for #1094 and this class is deprecated now.

@snicoll snicoll closed this as completed Aug 25, 2014
@snicoll snicoll removed this from the 1.2.0 milestone Aug 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: invalid An issue that we don't feel is valid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@snicoll @philwebb