Deprecate micrometer's enabled flags (in favour of excluding the auto-configuration)

[SpringBoot 2.0.2]
Currently you have only following properties to disable metric binders:

management.metrics.binders.files.enabled=false
management.metrics.binders.integration.enabled=false
management.metrics.binders.jvm.enabled=false
management.metrics.binders.logback.enabled=false
management.metrics.binders.processor.enabled=false
management.metrics.binders.uptime.enabled=false
management.metrics.web.server.auto-time-requests=false

Autoconfigured metric binders such as tomcat, rabbitmq cannot be disabled.
Please add properties to disable AutoConfiguration for these binders.

[snicoll]

This section of the doc explains how to disable metrics.

@jkschneider what are your thoughts on this? Are those enabled flag a different way of achieving the same thing or is there a performance impact to take into account?

[snicoll]

Autoconfigured metric binders such as tomcat, rabbitmq cannot be disabled.

@ramato-procon to be clear, my first comment was for you. They can be disabled, see the docs for more details.

[jkschneider]

@snicoll It depends on the binder. For example, the logback binder adds a TurboFilter that remains even if the metric is disabled from the perspective of an individual MeterRegistry.

[snicoll]

The mix between dedicated enabled flags and management.metrics.enable can be confusing and we don't want to add dedicated enabled flags for everything.

When users want to disable the feature altogether we request them to exclude the auto-configurations. For consistency, we should probably do that and deprecate those enabled flags.

@jkschneider please correct me if that's not an accurate summary of our discussion.

[jkschneider]

@snicoll I should add that generally binders use a name taxonomy that has a common prefix. So Tomcat metrics will all have names like tomcat.*. Setting management.metrics.enable.tomcat=false should be sufficient to disable all tomcat metrics emanating from that binder.

@snicoll
Thank you with management.metrics.enable.* I can disable all metrics.
Yes it is confusing to have 2 different properties for enabling the metric binders.

Also it would be nice to disable all metrics, but the own custom metrics.
Currently I need to add 8 lines to the properties file.

This doesn't work (mymetric is also disabled):

management.metrics.enable.all=false
management.metrics.enable.mymetric=true

[jkschneider]

That last bit seems like a bug @ramato-procon. The intended behavior is to match the most specific property.

[snicoll]

We've decided to deprecate the .enabled flags and redirect users to excluding the auto-configuration if they really want to do that (rather than using management.metrics.enable.*). I am not sure we'll have a fine grained auto-configuration model that matches those flags (perhaps all JVM metrics will stay in the same auto-config).