Spring WebFlux - Custom messages validation in different languages

[jakubdyszkiewicz]

Hello,

I've got a problem with providing custom messages in different languages for bean validation using WebFlux. It does not use messages for locale I send in header.

I think this is a bug because LocalValidatorFactoryBean uses LocaleContextMessageInterpolator. Hibernate Validator calls the public String interpolate(String message, Context context) method, which relays on the LocaleContextHolder. It uses a ThreadLocal which can't be used in WebFlux.

I created sample repository, I hope you find it helpful
https://github.com/jakubdyszkiewicz/webflux-validation

Thanks

[nosan]

Hello @jakubdyszkiewicz ,
WebMvc works because FrameworkServlet has a method FrameworkServlet.initContextHolders to set LocaleContextHolder.setLocaleContext(...). Seems like that WebFlux doesn't have such functionallity at least I haven't found it.

As a workaround you can override a default httpHandler:

@Bean
	@ConditionalOnWebApplication(type = ConditionalOnWebApplication.Type.REACTIVE)
	public HttpHandler httpHandler(ApplicationContext applicationContext) {
		HttpHandler delegate = WebHttpHandlerBuilder
				.applicationContext(applicationContext).build();
		return new HttpWebHandlerAdapter(((HttpWebHandlerAdapter) delegate)) {
			@Override
			protected ServerWebExchange createExchange(ServerHttpRequest request,
					ServerHttpResponse response) {
				ServerWebExchange serverWebExchange = super
						.createExchange(request, response);
				LocaleContext localeContext = serverWebExchange.getLocaleContext();
				if (localeContext != null) {
					LocaleContextHolder.setLocaleContext(localeContext);
				}
				return serverWebExchange;
			}
		};
	}

[snicoll]

thanks @nosan

@jakubdyszkiewicz this issue is related to WebFlux, the issue tracker of Spring Framework is here. Please report the issue with the sample there.