Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor org.springframework.boot.autoconfigure.security structure #14412

Open
philwebb opened this issue Sep 11, 2018 · 3 comments
Open

Refactor org.springframework.boot.autoconfigure.security structure #14412

philwebb opened this issue Sep 11, 2018 · 3 comments
Labels
type: task A general task
Milestone
3.x

Comments

@philwebb
Copy link
Member

The current structure is a bit messed up. We could do with a web package in there somewhere.
@philwebb philwebb added this to the 2.0.x milestone Sep 11, 2018
@philwebb philwebb added type: task A general task for: team-attention An issue we'd like other members of the team to review and removed for: team-attention An issue we'd like other members of the team to review labels Sep 11, 2018
@mbhave mbhave self-assigned this Sep 12, 2018
@philwebb philwebb modified the milestones: 2.0.x, 2.1.x Oct 4, 2018
@philwebb philwebb self-assigned this Oct 12, 2018
philwebb pushed a commit that referenced this issue Oct 16, 2018
@mbhave @philwebb
Preliminary restructure of security packages
f835f82 
Restructure the security auto-configuration packages to better reflect
the part of the system that the configuration applies to.

See gh-14412
philwebb added a commit that referenced this issue Oct 16, 2018
@philwebb
Merge branch 'gh-14412'
1d04fbc 
Closes gh-14412
@philwebb philwebb modified the milestones: 2.1.x, 2.1.0.RC1 Oct 16, 2018
@wilkinsona
Copy link
Member

I'm a bit worried about this breaking things. Any third-party starter that was using @AutoConfigureBefore or @AutoConfigureAfter and referencing one of the repackaged auto-configurations will be broken.

@wilkinsona wilkinsona reopened this Oct 16, 2018
@wilkinsona wilkinsona added the for: team-attention An issue we'd like other members of the team to review label Oct 16, 2018
@philwebb philwebb mentioned this issue Oct 17, 2018
Closed
@snicoll
Copy link
Member

snicoll commented Oct 17, 2018

Besides breaking use of auto-configurations, this actually moves EndpointRequest and PathRequest and breaks any user customizing security for actuator endpoints or static resources namely.

@snicoll snicoll removed the for: team-attention An issue we'd like other members of the team to review label Oct 17, 2018
@snicoll snicoll modified the milestones: 2.1.0.RC1, 2.x Oct 17, 2018
snicoll added a commit that referenced this issue Oct 17, 2018
@snicoll
Revert "Restructure of security packages"
474da80 
See gh-14412
@wilkinsona
Copy link
Member

For when we have another go at making this change, there was a bug in the newly restructured auto-configuration that meant that UserDetailsServiceAutoConfiguration could have its conditions evaluated before an ObjectPostProcessor bean had been defined. I fixed it like this.

@wilkinsona wilkinsona modified the milestones: 2.x, 3.x Jun 14, 2021
@scottfrederick scottfrederick added the status: blocked An issue that's blocked on an external project change label Nov 1, 2021
@wilkinsona wilkinsona modified the milestones: 3.x, 3.0.x Apr 27, 2022
@wilkinsona wilkinsona removed the status: blocked An issue that's blocked on an external project change label Apr 27, 2022
@wilkinsona wilkinsona removed this from the 3.0.x milestone Oct 3, 2022
@wilkinsona wilkinsona added this to the 3.x milestone Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: task A general task
Projects
None yet
Milestone
3.x
Development

No branches or pull requests
5 participants
@scottfrederick @snicoll @philwebb @wilkinsona @mbhave