Skip to content

Add some javax.* dependencies to BOM file #17059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
altro3 opened this issue Jun 5, 2019 · 4 comments
Closed

Add some javax.* dependencies to BOM file #17059

altro3 opened this issue Jun 5, 2019 · 4 comments
Labels
status: superseded An issue that has been superseded by another

Comments

@altro3
Copy link

altro3 commented Jun 5, 2019

Hi! For working in JDK11 will be cool add versions for some dependencies:

"javax.jws:javax.jws-api:1.1"
"jakarta.jws:jakarta.jws-api:1.1.1"
"javax.activation:activation:1.1.1"
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 5, 2019
@wilkinsona
Copy link
Member

javax.jws:javax.jws-api:1.1

We haven't seen any need for this dependency with Spring Boot. It isn't used by Spring Web Services, for example, which uses javax.xml.ws:javax.xml.ws-api. What do you need it for?

jakarta.jws:jakarta.jws-api:1.1.1

There doesn't appear to be a jakarta.jws group in Maven Central. Can you please clarify?

javax.activation:activation:1.1.1

You should use javax.activation:javax.activation-api which is already managed. Boot 2.2 adds management for jakarta.activation:jakarta.activation-api.

@wilkinsona wilkinsona added the status: waiting-for-feedback We need additional information before we can continue label Jun 5, 2019
@altro3
Copy link
Author

altro3 commented Jun 5, 2019

  1. In this case, I proceed from my needs. After switching to Java 11, I had to figure out how to work with JavaEE web services (many banks use them); to minimize coding, I chose apache CXF as the code generator. The generated client class uses annotations from javax.jws-api (jakarta.jws-api):
import javax.jws.WebMethod;
import javax.jws.WebParam;
import javax.jws.WebResult;
import javax.jws.WebService;
import javax.jws.soap.SOAPBinding;

And also, since this is part of the java EE cut from the JDK and you have added almost all versions of dependencies, are required to work in JDK 11, it’s logical to add this dependency for completeness

  1. About jakarta.jws: https://mvnrepository.com/artifact/jakarta.jws/jakarta.jws-api/1.1.1

  2. Yes, of course, in most cases, activation-api is enough. But the problem is the separation of javax.activation-api and javax.activation: the classes javax.activation.MailcapCommandMap and javax.activation.MimetypesFileTypeMap from activation-api use the class from activation, you can see the sources here: https://github.com/javaee/activation/blob/master/activation/src/main/java/javax/activation/MailcapCommandMap.java. Same problem in jakarta.activation:activation-api. Another words, if you using activation-api, most likely you need add activation dependency too.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Jun 5, 2019
@wilkinsona
Copy link
Member

  1. To limit the scope of our dependency management to something that is maintainable, we only manage dependencies that Spring Boot interacts with either directly or indirectly. There's no such interaction with JWS so providing dependency management for it is out of scope.

  2. Sorry, I'm not sure how I missed that earlier. However, the same applies here as applies to javax.jws:javax.jws-api so it's out of scope too.

  3. The dependency management that we provide for Javax Activation is version 1.2 where the implementation jar has the coordinates com.sun.activation:javax.activation or com.sun.activation:jakarta.activation. We should have dependency management for this as it's part of the same project as the API dependencies that we already manage. I've opened Dependency management for JavaBeans Activation Framework is incomplete #17062 to correct that.

@wilkinsona wilkinsona added status: superseded An issue that has been superseded by another and removed status: feedback-provided Feedback has been provided status: waiting-for-triage An issue we've not yet triaged labels Jun 5, 2019
@altro3
Copy link
Author

altro3 commented Jun 5, 2019

  1. and 2. ok, understood

  2. yeah, will be great. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Development

No branches or pull requests

3 participants