Skip to content

Add auto-creation of retry topics to Spring Kafka non-blocking retries auto-configuration #34046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tomazfernandes opened this issue Feb 1, 2023 · 2 comments
Labels
status: declined A suggestion or change that we don't feel we should currently apply

Comments

@tomazfernandes
Copy link
Contributor

When auto-configuration for Spring for Apache Kafka's Non-Blocking Delayed Retries feature was implemented, automatic creation of topics was disabled by default.

We should allow users to override that configuration for speeding up development.

My proposal is to add the following properties:

spring.kafka.retry.topic.create.retry-topics=true
spring.kafka.retry.topic.create.partitions=2
spring.kafka.retry.topic.create.replication-factor=3

Or, if we want less options:

spring.kafka.retry.topic.auto-create-retry-topics=true

How does that look? I can open a PR once we reach an agreement, and we can change any properties names.

Here are the docs for the feature, and here for topics auto-creation. Please let me know if you have any questions.

@garyrussell and @artembilan, feel free to pitch in if you have the time.

Thanks!

@tomazfernandes
Copy link
Contributor Author

I gave some more thought on this, and perhaps we should keep it as simple as possible and have a single property:

spring.kafka.retry.topic.auto-create-topics=true

If users want more complex configurations than that they can provide their own configuration programmatically, and if users request further auto-configuration options we can always add them later.

I've opened a PR for this but if we decide to go another direction that's ok.

Thanks!

@wilkinsona
Copy link
Member

We’re cleaning out the issue tracker and closing issues that we’ve not seen much demand to fix. Feel free to comment with additional justifications if you feel that this one should not have been closed.

@wilkinsona wilkinsona closed this as not planned Won't fix, can't repro, duplicate, stale Jun 4, 2024
@wilkinsona wilkinsona added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants