Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Reactor Netty in ClientHttpRequestFactories #42587

Closed
rstoyanchev opened this issue Oct 10, 2024 · 4 comments
Closed

Support Reactor Netty in ClientHttpRequestFactories #42587

rstoyanchev opened this issue Oct 10, 2024 · 4 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@rstoyanchev
Copy link
Contributor

RestClient support in #36213 was followed by JDK HttpClient and Jetty client support in ClientHttpRequestFactories, #36118 and #36116. ReactorClientHttpRequestFactory was added soon after in Spring Framework, but there is no corresponding support in ClientHttpRequestFactories as of yet.

Note that ReactorClientHttpRequestFactory was called ReactorNettyClientRequestFactory in 6.1, but was recently renamed in spring-projects/spring-framework@042346a. In case you wonder why it's marked with @since 6.2.

@spencergibb
Copy link
Member

I wonder, if like the jdk http client, this should be opt-in by default in a minor. spring-cloud/spring-cloud-gateway#3562

spencergibb added a commit to spencergibb/spring-cloud-gateway that referenced this issue Oct 22, 2024
Since spring-projects/spring-boot#42587, the default http client changed when webflux is on the classpath.

Fixes spring-cloudgh-3562
@philwebb philwebb reopened this Oct 22, 2024
@philwebb
Copy link
Member

Reopening to consider if we should make this opt-in (similar to jdk http client)

@philwebb philwebb added the for: team-meeting An issue we'd like to discuss as a team to make progress label Oct 22, 2024
@spencergibb
Copy link
Member

One backward incompatibility was not sending the body on a DELETE.

spencergibb added a commit to spring-cloud/spring-cloud-gateway that referenced this issue Oct 22, 2024
Since spring-projects/spring-boot#42587, the default http client changed when webflux is on the classpath.

Fixes gh-3562
@philwebb philwebb removed the for: team-meeting An issue we'd like to discuss as a team to make progress label Oct 25, 2024
@philwebb
Copy link
Member

We're going to keep it as a default, but #36266 will make it easier to change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

5 participants