Skip to content

Remove support for management.otlp.metrics.export.resource-attributes that has been deprecated since 3.2 #44468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wilkinsona opened this issue Feb 27, 2025 · 2 comments
Closed

Remove support for management.otlp.metrics.export.resource-attributes that has been deprecated since 3.2 #44468

wilkinsona opened this issue Feb 27, 2025 · 2 comments
Assignees
@wilkinsona
Labels
type: enhancement A general enhancement
Milestone
3.5.0-M3

Comments

@wilkinsona
Copy link
Member

As discussed in #44394, the property has been deprecated since 3.2 when management.opentelemetry.resource-attributes was introduced as its replacement. It should have been removed in 3.4 but we missed it. To avoid a breaking change in a 3.4.x maintenance release, remove it in 3.5.
@wilkinsona wilkinsona added the type: enhancement A general enhancement label Feb 27, 2025
@wilkinsona wilkinsona added this to the 3.5.x milestone Feb 27, 2025
@wilkinsona wilkinsona self-assigned this Feb 27, 2025
@wilkinsona wilkinsona mentioned this issue Feb 27, 2025
Closed
@wilkinsona wilkinsona modified the milestones: 3.5.x, 3.5.0-M3 Feb 27, 2025
@nosan
Copy link
Contributor

nosan commented Feb 27, 2025 •
edited
Loading

@wilkinsona
You forgot about these two: 😄

  • GrafanaOpenTelemetryMetricsContainerConnectionDetailsFactoryIntegrationTests
  • OpenTelemetryMetricsContainerConnectionDetailsFactoryIntegrationTests

@wilkinsona
Copy link
Member Author

🙄 That's what I get for running the build with Docker disabled.

wilkinsona added a commit that referenced this issue Feb 27, 2025
@wilkinsona
Switch to management.opentelemetry.resource-attributes in tests
9364879 
See gh-44468
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilkinsona wilkinsona

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.5.0-M3
Development

No branches or pull requests
2 participants
@wilkinsona @nosan