-
Notifications
You must be signed in to change notification settings - Fork 41.2k
Ability to specify health endpoint not-sensitive w/o disabling security #5750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This table in the documentation summarizes the current situation. Given that I am asking because while I agree it would be nice to have, I fail to see how we could implement that consistently without more headache... |
Seems like we ran out of time to get any change into 1.4. There's always a workaround if you want to set up your own security for /health. E.g. a quick and dirty way to do it is to just add /health to the |
@snicoll Perhaps an additional option? Even just exposing the name of the health checks that failed would be enough. Basically a way to say "DB is down, but Rabbit + Redis are still looking good." without having to worry about authentication. What if @dsyer I tried that quick and dirty a while back and ran into issues, as some of the common checks throw NPEs w/o a user in the context (forget which – need to log an issue for that independently either way now that I think about it) |
I don't think we should be that fine-grained as it'll add more confusion for something that is already hard to grasp for beginners. What we need is essentially an additional flag that states "just show everything". I would very much prefer that sensitive becomes an enum but that's not going to happen in 1.4 |
Fair enough. I agree that's the best solution. We can definitely wait on this for now. I'm happy to contribute a PR to this, if you all want to weigh in on how this should go about. Would the enum route apply only to health? |
I don't know at this point. How about giving that a try and report here? Thanks! |
#9721 will remove the need for having to disable all management security to display health details to authenticated users. |
Duplicate of #9721 |
@ionutincau This has been solved in 2.0 M4 by #9721. We now have |
Currently, the only way to get the
health
endpoint to show the details of adown
ed service is to setendpoints.health.sensitive=false
andmanagement.security.enabled=false
The latter seems overly restrictive to me. We'd still like to keep the majority of our endpoints (env, trace, etc) secured, but it'd be nice to have health give more details.
Maybe having a third state like
sensitive
,insensitive
, anddetailed
(for lack of a better word) where the health beans could determine how much detail to provide based on setting?Open to any suggestions, just know I've run up to this many times and others have shared my thoughts. Also, happy to contribute to whatever is determined to be the best course :)
The text was updated successfully, but these errors were encountered: