Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistently use bytes as the unit for all memory-related metrics #6413

Closed
aantono opened this issue Jul 18, 2016 · 2 comments
Closed

Consistently use bytes as the unit for all memory-related metrics #6413

aantono opened this issue Jul 18, 2016 · 2 comments

Comments

@aantono
Copy link
Contributor

aantono commented Jul 18, 2016

Enhancement request:
Provide ability to specify the unit of measurement for memory metrics.
Currently all the metrics extracted via MemoryUsage mBean are automatically converted to Kb unit of measurement, instead of original bytes, which causes issues for migrated applications, that used to rely on Dropwizard JVM MemoryUsageGaugeSet to export the same metrics, which used bytes as a unit of measurement. (Also, IMHO, it would be beneficial for others, who choose/want/need to get memory metrics in bytes instead of Kb).

Maybe adding a property (something along the lines of memoryMetricUnitMultiplier) with default value of 1024, but externally configurable, to allow custom selection of units?
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 18, 2016
@philwebb philwebb added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 18, 2016
@wilkinsona
Copy link
Member

IMO, bytes should be the default unit. It seems strange to use a default that causes a loss of precision

@philwebb philwebb added the for: team-attention An issue we'd like other members of the team to review label Jul 19, 2016
@philwebb philwebb added this to the 2.0.0 milestone Jul 20, 2016
@snicoll snicoll removed the for: team-attention An issue we'd like other members of the team to review label Jul 20, 2016
joshiste added a commit to codecentric/spring-boot-admin that referenced this issue Jul 21, 2016
@joshiste
Fix memory units for dorpwizard metrics-jvm
39afa3b 
In case dropwizard is used the heap metrics are in bytes and not in kilobytes.
This is deteceted by the presence of heap.max. For Spring Boot 2.0 there is an
issue filed to deliver bytes see spring-projects/spring-boot#6413

fixes #234
@wilkinsona wilkinsona changed the title Allow to configure the unit of memory for "Memory" metrics Consistently use bytes as the unit for all memory-related metrics Aug 30, 2016
@bclozel bclozel mentioned this issue Aug 31, 2016
Closed
@wilkinsona
Copy link
Member

This has been superseded by the planned move to Micrometer-based metrics (#9970)

@wilkinsona wilkinsona removed this from the 2.0.0 milestone Aug 11, 2017
ejavexpert added a commit to ejavexpert/java-spring-boot-admin that referenced this issue Mar 25, 2022
@ejavexpert
Fix memory units for dorpwizard metrics-jvm
3fb7c35 
In case dropwizard is used the heap metrics are in bytes and not in kilobytes.
This is deteceted by the presence of heap.max. For Spring Boot 2.0 there is an
issue filed to deliver bytes see spring-projects/spring-boot#6413

fixes #234
KingSize0319 added a commit to KingSize0319/spring-boot-admin that referenced this issue Feb 6, 2023
@KingSize0319
Fix memory units for dorpwizard metrics-jvm
90a614b 
In case dropwizard is used the heap metrics are in bytes and not in kilobytes.
This is deteceted by the presence of heap.max. For Spring Boot 2.0 there is an
issue filed to deliver bytes see spring-projects/spring-boot#6413

fixes #234
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@aantono @snicoll @philwebb @wilkinsona @spring-projects-issues