Skip to content

Metrics filter may submit metrics with regular expressions in their name #7503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wilkinsona opened this issue Nov 28, 2016 · 0 comments
Closed
Assignees
Labels
type: bug A general bug
Milestone

Comments

@wilkinsona
Copy link
Member

If a request mapping variable is constrained with a regular expression, metrics filter includes the regular expression in the name of the metric. For example, a request that's handled by @RequestMapping("/foo/{bar:[a-z]+}") and has a 200 OK response will result in a metric named status.200.foo.bar:[a-z]+ being submitted.

This behaviour isn't documented anywhere and doesn't appear to be covered by the tests. I suspect that it is not intentional, particularly as we replace ** with -star-star- and * with -star-. This replacement means that someVariable:[a-z]* becomes some-variable:[A-Z]-star-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

No branches or pull requests

1 participant