Skip to content

Extract database type from JDBC URL and forward to Hibernate #7708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
odrotbohm opened this issue Dec 20, 2016 · 4 comments
Closed

Extract database type from JDBC URL and forward to Hibernate #7708

odrotbohm opened this issue Dec 20, 2016 · 4 comments
Labels
status: superseded An issue that has been superseded by another

Comments

@odrotbohm
Copy link
Member

It looks like that I have to configure spring.jpa.database explicitly when I use spring.datasource.url. The latter is a common approach when e.g. moving from embedded H2/HSQL to a persistent local one. It would be cool if Boot would derive the value to use for the former based on the JDBC URL configured similar to what it does for the JDBC driver class.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 20, 2016
@philwebb philwebb added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 21, 2016
@snicoll
Copy link
Member

snicoll commented Dec 22, 2016

Funny that our documentation states "auto-detected by default". That's quite misleading!

@chris-denglere
Copy link

chris-denglere commented Dec 27, 2016

Hey team,

I'm new to the project on github, but have used STS some previously. Would this enhancement be a good place for me to start contributing? Thanks!

@snicoll
Copy link
Member

snicoll commented Dec 27, 2016

Chris, those issues are typically flagged with ideal-for-contribution. Feel free to review those and the contributing documentation. Thanks!

eddumelendez added a commit to eddumelendez/spring-boot that referenced this issue Dec 30, 2016
Previously, property `spring.jpa.database` should be provided. This
commit allows to detect the database when `spring.datasource.url` is
provided.

See spring-projectsgh-7708
@philwebb philwebb added this to the 1.5.0 RC1 milestone Dec 30, 2016
eddumelendez added a commit to eddumelendez/spring-boot that referenced this issue Dec 31, 2016
Previously, property `spring.jpa.database` should be provided. This
commit allows to detect the database when `spring.datasource.url` is
provided.

See spring-projectsgh-7708
eddumelendez added a commit to eddumelendez/spring-boot that referenced this issue Dec 31, 2016
Previously, property `spring.jpa.database` should be provided. This
commit allows to detect the database when `spring.datasource.url` is
provided.

See spring-projectsgh-7708
eddumelendez added a commit to eddumelendez/spring-boot that referenced this issue Dec 31, 2016
Previously, property `spring.jpa.database` should be provided. This
commit allows to detect the database when `spring.datasource.url` is
provided.

See spring-projectsgh-7708
@snicoll
Copy link
Member

snicoll commented Jan 3, 2017

Closing in favor of PR #7796

@snicoll snicoll closed this as completed Jan 3, 2017
@snicoll snicoll removed this from the 1.5.0 RC1 milestone Jan 3, 2017
@snicoll snicoll added status: duplicate A duplicate of another issue and removed type: enhancement A general enhancement labels Jan 3, 2017
snicoll pushed a commit that referenced this issue Jan 3, 2017
Previously, property `spring.jpa.database` should be provided. This
commit allows to detect the database when `spring.datasource.url` is
provided.

Closes gh-7708
snicoll added a commit that referenced this issue Jan 3, 2017
* pr/7796:
  Polish contribution
  Autodetect spring.jpa.database from spring.datasource.url
@philwebb philwebb added status: superseded An issue that has been superseded by another and removed status: duplicate A duplicate of another issue labels Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Development

No branches or pull requests

5 participants