-
Notifications
You must be signed in to change notification settings - Fork 40.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve CounterService operations #8800
Comments
We intentionally wanted to keep In the mean time, you can use |
Thanks @dsyer those are new to me. I can not find any write ups. Would we create a @PublicMetrics service that contains the CounterBuffers we want to use? |
It depends what you want to happen. There is already an instance of |
I will still vote for overloading the increment/decrement methods for easier implementation of batch oriented metrics |
This has been superseded by the planned move to Micrometer-based metrics (#9970) |
While reviewing some projects new to me today, I saw several cases of
CounterService
being in a for loop in order to have counters on batch processes. I was wondering if it had been discussed to allowincrement
anddecrement
in values other than one?Since internally
Delta
already has this concept it does not seem challenging to extend the service interface itself. Any thoughts @dsyer or others?Joshua
The text was updated successfully, but these errors were encountered: