Auto-configure Jersey2 server instrumentation

[mweirauch]

This PR auto-configures the Micrometer Jersey2 server instrumentation. It's adopted from the micrometer-spring-legacy auto-configuration.

Relates to gh-12447 and micrometer-metrics/micrometer#486

[mweirauch]

This is just for completeness sake in case somebody is going to use the MetricsRun tooling in other tests. It's not used in the Jersey auto-configuration tests.

[MarkusKull]

Did a quick test by copying this configuration into a jersey application with prometheus: Some uri-tags are now indeed templated. But raw uris are additionally recorded, probably because both MVC- and Jersey-RequestFilters apply to a http request. As quick workaround the jersey-meters were renamed and MVC-meters were suppressed by a MeterFilter.
A better fix could simply disable the MVC-Filter when encountering Jersey. Or MVC should omit recording when seeing a RequestAttribute set by Jersey-Filter.

[mweirauch]

Yap. WebMVC instrumentation kicks in. One could disable WebMvcMetricsAutoConfiguration in that case. Alternatively configure Jersey to work in servlet-filter mode and set it's filter order to -2147483648. That at least work in Spring-Boot 1.5. (Haven't tested Jersey pass-through of requests it doesn't handle, though.)

[philwebb]

We might rework this depending on how the implementation of #13064 goes.

[snicoll]

There is also another implementation for the same feature in #12905 that we should review as part of merging this.

[mweirauch]

After some time has passed, what's your stance on this PR? #13064 hasn't seen any progress as of yet.

We are slowly moving to Spring Boot 2 services and I remembered this being still open. It's not hard to come up with a custom/proprietary setup for the time being, but it would be cool to not have to care about Jersey instrumentation in the future. (Even if it might get reworked with #13064.)

[philwebb]

@mweirauch We're still hoping to get to this one if we can.

[mweirauch]

Just in case, I went ahead and updated the PR against master/2.1.x.

Contains parts of #12905 and credited @michael-simons where appropriate. (Hope this is ok dear "Namensvetter" ;))

[wilkinsona]

I think we should merge this one rather than #12905, with a single squashed commit amended to list @michael-simons as a co-author.

[wilkinsona]

There are some differences in Micrometer's Jersey tag support and what it and Boot offer for Web MVC. I've opened micrometer-metrics/micrometer#900 to try and align things. I don't think it needs to block merging this.

[wilkinsona]

In the absence of #13064, I think what's proposed here plus a little polishing is sufficient. In the polishing, I've added a filter that applies management.metrics.web.server.max-uri-tags to Jersey metrics. The Spring MVC metrics filter is conditional on the presence of DispatcherServlet. I think applications that depend on both Jersey and MVC will be in the minority. Those that do can customise things to meet their needs, for example by disabling WebMvcMetricsAutoConfiguration as proposed above. We can iterate on this based on the feedback we get, and then hopefully improve things significantly in a 2.x release that includes #13064.

[wilkinsona]

@mweirauch, thank you for making your first contribution to Spring Boot. @michael-simons, thanks for your contribution here too. You are a co-author of dd126fa. The proposed changes are now in master. I polished things a little in 72e2313. Other than some repackaging, the main changes were to a meter filter and to reuse the management.metrics.web.server properties rather than adding Jersey-specific properties.

[mweirauch]

Thanks @wilkinsona for taking care of this!