Split compound if statement in two so that Graal's native image builder is happy #13711
+7
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some static analysis tools will barf on BeanDefinitionLoader when Groovy is not on the classpath (e.g. Graal VM native image builder). The problem can be avoided just by nesting the "if" clause containing the Groovy reference inside a defensive outer "if".
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
changed the title
|
Equally, some static analysis tools will complain that the two if statements should be combined into one. I'm surprised that Checkstyle hasn't done so. We can merge this if really necessary, but I'd prefer that it was fixed in Graal rather than it forcing lots of projects to make their code a little bit worse. |
|
Perhaps we can extract a method to make it look a little less odd. @dsyer Is there an open Graal issue for this? |
|
There is a graal issue and they marked it as a bug, so maybe we do not need the do this here. |
|
Yeah, looks like this hopefully won't be needed. I've subscribed to the Graal issue. I'll close this one for now and we can re-open it if the Graal issue doesn't help. |
wilkinsona
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some static analysis tools will barf on BeanDefinitionLoader when Groovy is not on the classpath (e.g. Graal VM native image builder). The problem can be avoided just by nesting the "if" clause containing the Groovy reference inside a defensive outer "if".