Skip to content

Using ObjectProvider<T> with ordered list access instead of ObjectProvider<List<T>> #14472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Using ObjectProvider<T> with ordered list access instead of ObjectProvider<List<T>> #14472

wants to merge 1 commit into from

Conversation

ayudovin
Copy link
Contributor

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 14, 2018
@wilkinsona
Copy link
Member

Thanks for the PR, but ObjectProvider has be re-worked in the latest Framework snapshots (which is what prompted the opening of #14467. We also want to look at each current usage in turn and decide the best method to use in each case. Sorry for the wasted effort on your part. I'd recommend commenting on an issue before you start working on it so that we can let you know about this sort of thing in advance.

@wilkinsona wilkinsona closed this Sep 14, 2018
@wilkinsona wilkinsona added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 14, 2018
@ayudovin
Copy link
Contributor Author

@wilkinsona, ok, it's my mistake, sorry.
Thank you for advice.

@ayudovin ayudovin deleted the use-objectprovide-instead-objectprovider-list branch September 14, 2018 15:02
@ayudovin ayudovin restored the use-objectprovide-instead-objectprovider-list branch September 14, 2018 15:02
@ayudovin ayudovin deleted the use-objectprovide-instead-objectprovider-list branch September 14, 2018 15:02
@ayudovin ayudovin restored the use-objectprovide-instead-objectprovider-list branch September 14, 2018 15:02
@ayudovin ayudovin deleted the use-objectprovide-instead-objectprovider-list branch September 14, 2018 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayudovin @wilkinsona @spring-projects-issues