Use non-reflective APIs to inject converters #14657
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
dsyer
force-pushed
the
converters
branch
2 times, most recently
from
80af744 to
8c89826
Compare
|
I share your dislike of having to force the factory method to initialise itself. Hopefully you'll get some traction on SPR-8891. |
|
Looks like SPR-8891 might be in 5.1.1. I think we should hold off until that's in. |
philwebb
added
type: task
dsyer
force-pushed
the
converters
branch
4 times, most recently
from
b3d4af6 to
0df7131
Compare
The @qualifier APIs are a bit limited in Spring still, so we might want to use this to pursue additional convenience methods before merging.
SPR-8891 is still in flux. It might settle down so we don't need the hack, but for now this is needed to make the factory method for converter beans available in time to select them by qualifier.
|
Those 4 commits can be squashed together. SPR-8891 is now resolved and this looks like it works, |
wilkinsona
removed
the
status: blocked
wilkinsona
pushed a commit
that referenced
this pull request
Oct 14, 2018
wilkinsona
added a commit
that referenced
this pull request
Oct 14, 2018
* gh-14657: Polish "Use non-reflective APIs to retrieve config prop binding converters" Use non-reflective APIs to retrieve config prop binding converters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@QualifierAPIs are a bit limited in Spring still, so we mightwant to use this to pursue additional convenience methods before
merging. See SPR-8891.