Skip to content

Rename ElasticSearchJestHealthIndicatorAutoConfiguration #15723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Rename ElasticSearchJestHealthIndicatorAutoConfiguration #15723

wants to merge 1 commit into from

Conversation

ayudovin
Copy link
Contributor

@ayudovin ayudovin commented Jan 16, 2019 •
edited
Loading

Rename ElasticSearchJestHealthIndicatorAutoConfiguration to ElasticsearchJestHealthIndicatorAutoConfiguration
this task

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 16, 2019
@snicoll snicoll mentioned this pull request Jan 16, 2019
Closed
@snicoll snicoll added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 16, 2019
@snicoll snicoll added this to the 2.2.x milestone Jan 16, 2019
@mbhave
Copy link
Contributor

mbhave commented Jan 16, 2019

#14881 is a similar issue which is currently on hold for the deprecated auto-config support which will enable it to be implemented in a non-breaking manner. It seems inconsistent to do this before #14860 given that moving a class is less of a breaking change than renaming it since the IDE will be able to find it in the former case.

@ayudovin
Copy link
Contributor Author

@mbhave, does it mean that this pull request should be on hold until #14860 is done?

@mbhave
Copy link
Contributor

mbhave commented Jan 23, 2019

@ayudovin Sorry, I should've been a bit more clear about what I meant. The comment was for the team to consider that there could be such inconsistencies before merging the PR. The milestone would be decided based on what the team decides.

@ayudovin
Copy link
Contributor Author

@mbhave, ok, no problem

@snicoll snicoll added for: team-attention An issue we'd like other members of the team to review and removed for: team-attention An issue we'd like other members of the team to review labels Feb 14, 2019
@snicoll
Copy link
Member

snicoll commented Feb 15, 2019

Thank you for the PR but there are actually 3 auto-configuration classes with the same problem and we don't believe adding a breaking change in 2.2 for this is worthwhile. We can reconsider when #14860 is implemented and we can group all three in a single auto-configuration. Right now they are split to benefit from the optimization of skipping the auto-configuration if the client library is not on the classpath.

@snicoll snicoll closed this Feb 15, 2019
@snicoll snicoll added status: declined A suggestion or change that we don't feel we should currently apply and removed type: task A general task labels Feb 15, 2019
@snicoll snicoll removed this from the 2.2.x milestone Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ayudovin @mbhave @snicoll @spring-projects-issues