Recommend configuring compileJava's inputs to include processResources' output when generating configuration metadata #20323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`compileJava.dependsOn(processResources)` is not enough to ensure the correct behavior. Using `dependsOn` only affects the execution order (`processResources` before `compileJava`) but not the up-to-date check of `compileJava`: After modifying `META-INF/additional-spring-configuration-metadata.json` the `processResouces` task will considered out-of-date and will be re-executed, but after that `compileJava` will still be considered up-to-date which causes the changes not to be merged into `META-INF/spring-configuration-metadata.json` With this change the up-do-date check of `compileJava` is affected, too. Therefore it will correctly re-execute the configuration-processor when `META-INF/additional-spring-configuration-metadata.json` was changed.
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
added
type: documentation
wilkinsona
changed the title
|
Thanks very much, @larsgrefer. The proposed change is now in 2.2.x and master. |
wilkinsona
pushed a commit
that referenced
this pull request
Mar 18, 2020
`compileJava.dependsOn(processResources)` is not enough to ensure the correct behavior. Using `dependsOn` only affects the execution order (`processResources` before `compileJava`) but not the up-to-date check of `compileJava`. After modifying `META-INF/additional-spring-configuration-metadata.json`, the `processResouces` task will considered out-of-date and will be re-executed, but after that `compileJava` will still be considered up-to-date which causes the changes not to be merged into `META-INF/spring-configuration-metadata.json` With this change the up-do-date check of `compileJava` is affected, too. Therefore, it will correctly re-execute the configuration-processor when `META-INF/additional-spring-configuration-metadata.json` was changed. See gh-20323
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compileJava.dependsOn(processResources)is not enough to ensure the correct behavior.Using
dependsOnonly affects the execution order (processResourcesbeforecompileJava) but not the up-to-date check ofcompileJava: After modifyingMETA-INF/additional-spring-configuration-metadata.jsontheprocessResoucestask will considered out-of-date and will be re-executed, but after thatcompileJavawill still be considered up-to-date which causes the changes not to be merged intoMETA-INF/spring-configuration-metadata.jsonWith this change the up-do-date check of
compileJavais affected, too. Therefore it will correctly re-execute the configuration-processor whenMETA-INF/additional-spring-configuration-metadata.jsonwas changed.Related Issues:
#9758
#9732